Skip to content

dom_fix_form_task#1839

Open
TarasYelahin wants to merge 1 commit intomate-academy:masterfrom
TarasYelahin:develop
Open

dom_fix_form_task#1839
TarasYelahin wants to merge 1 commit intomate-academy:masterfrom
TarasYelahin:develop

Conversation

@TarasYelahin
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! Your script correctly creates and appends the labels and placeholders as required. I'm approving your solution because it meets all the core requirements.

As a point for future improvement, consider making your element selector more specific. The requirement was to get inputs from the <form> tag. While document.querySelectorAll('input') works here, a more precise selector like document.querySelectorAll('form input') would be more robust and align more closely with the instructions. This is a good practice to ensure your code only affects the intended elements.

Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

'use strict';

// write code here
const inputs = document.querySelectorAll('input');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement specifies to "Get all inputs from form tag on the page". Your current selector input selects all input elements on the entire document. To adhere to the requirement more strictly, you should use a more specific selector like 'form input'. This ensures you only modify inputs that are descendants of a <form> element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants