Skip to content

task solved#1843

Open
JorJio-svg wants to merge 2 commits intomate-academy:masterfrom
JorJio-svg:develop
Open

task solved#1843
JorJio-svg wants to merge 2 commits intomate-academy:masterfrom
JorJio-svg:develop

Conversation

@JorJio-svg
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Good work on this task! You've correctly set up the script to iterate through the inputs and create the label elements. However, one critical requirement is not being met, which is why I'm requesting a change. The labels are being created without any visible text because the textContent is being set on the input element instead of the label element. Please find the line where you set input.textContent and change it to set the textContent on your label variable instead. With that small fix, your solution will be perfect!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

label.classList.add('field-label');
label.htmlFor = input.id;
input.placeholder = capitalized;
input.textContent = inputName;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires setting the textContent for the label element, but here you are setting it on the input element instead. The label element is the one that should display the text based on the input's name.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work! I am approving this pull request. You've successfully addressed the feedback from the previous review, and the script now correctly sets the textContent on the label element. Your solution perfectly meets all the task requirements. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants