Skip to content

solution#1844

Open
Tanya-sktr wants to merge 2 commits intomate-academy:masterfrom
Tanya-sktr:develop
Open

solution#1844
Tanya-sktr wants to merge 2 commits intomate-academy:masterfrom
Tanya-sktr:develop

Conversation

@Tanya-sktr
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great work on this task! I am approving your solution as it correctly adds the required labels and placeholders to the form inputs. The logic is clean and meets all the core functional requirements.

One small point of feedback for the future: the task required selecting input elements specifically from within the <form>. Your selector document.querySelectorAll('input') works here, but a more precise approach would be document.querySelectorAll('form input'). This ensures that if other inputs ever existed outside the form, your script wouldn't unintentionally select them.

This is a minor detail and your code works perfectly for the current page. Well done!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

'use strict';

// write code here
const inputs = document.querySelectorAll('input');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires getting all input elements from the form tag. This selector will get all input elements on the entire page, which might not be what's intended if there were other inputs outside the form. Consider making the selector more specific, for example, 'form input'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants