Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on this task! The core logic for calculating age and century is implemented correctly. However, one adjustment is needed before this can be approved. The 'gender' column in the generated table should display 'm' or 'f' as shown in the task's 'Expected result' image. Your current implementation converts these values to 'Male' and 'Female'. Please update the code in src/scripts/main.js to use the person.sex value directly. After that small change, everything will be perfect!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| const genderCell = document.createElement('td'); | ||
|
|
||
| genderCell.textContent = person.sex.toLowerCase() === 'm' ? 'Male' : 'Female'; |
There was a problem hiding this comment.
This is a good attempt at making the data more user-friendly. However, according to the 'Expected result' image in the task description, the gender column should display 'm' or 'f' directly. Please use the person.sex value without converting it to 'Male' or 'Female'.
3 participants
No description provided.