Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm start & sleep 5 && npm test
- name: Upload tests report(cypress mochaawesome merged HTML report)
if: ${{ always() }}
uses: actions/upload-artifact@v2
with:
name: report
path: reports
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_task_parse_list_DOM/)
1. Replace `Kateryna7465` with your Github username in the link
- [DEMO LINK](https://<Kateryna7465>.github.io/js_task_parse_list_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
Expand All @@ -10,14 +10,14 @@
Hey there! Can you parse data from the list and sort it based on data attributes?

Your task: Sort list by salary in descending order.
Get an array of employees. Write two functions:
Get an array of employees. Write two functions:
- first, which sorts the list by salary from data attributes
- second, which returns an array of objects, where objects are employees.

The schema for the employee:
```
{
name,
name,
position,
salary,
age
Expand Down
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@linthtml/linthtml": "^0.9.6",
"@mate-academy/eslint-config": "latest",
"@mate-academy/linthtml-config": "latest",
"@mate-academy/scripts": "^1.8.5",
"@mate-academy/scripts": "^2.1.3",
"@mate-academy/stylelint-config": "latest",
"@parcel/transformer-sass": "^2.12.0",
"cypress": "^13.13.0",
Expand Down
40 changes: 39 additions & 1 deletion src/scripts/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,41 @@
'use strict';
const list = document.querySelector('ul');

Check failure on line 3 in src/scripts/main.js

View workflow job for this annotation

GitHub Actions / build (20.x)

'list' is assigned a value but never used
function getSalary(item) {
return Number(
item.dataset.salary
.replace(/[S,]/g, '')
);
}

Check failure on line 9 in src/scripts/main.js

View workflow job for this annotation

GitHub Actions / build (20.x)

'list' is already declared in the upper scope on line 3 column 7

function sortList(list) {
const items = [...list.children];

items.sort((a, b) => {
return getSalary(b) - getSalary(a)
});

list.append(...items);

Check failure on line 19 in src/scripts/main.js

View workflow job for this annotation

GitHub Actions / build (20.x)

'list' is already declared in the upper scope on line 3 column 7

Check failure on line 19 in src/scripts/main.js

View workflow job for this annotation

GitHub Actions / build (20.x)

'getEmployees' is defined but never used
}

function getEmployees(list) {
const items = [...list.children];

return items.map(item => ({
name: item.textContent.trim(),
position: item.dataset.position,
salary: getSalary(item),
age: Number(item.dataset.age)

Check failure on line 29 in src/scripts/main.js

View workflow job for this annotation

GitHub Actions / build (20.x)

Unreachable code

}))

Check failure on line 31 in src/scripts/main.js

View workflow job for this annotation

GitHub Actions / build (20.x)

'employees' is assigned a value but never used

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreachable code - sortList(list) on line 32 is placed after the return statement, making it unreachable. This should be called at module level, not inside getEmployees.

sortList(list);

Check failure on line 33 in src/scripts/main.js

View workflow job for this annotation

GitHub Actions / build (20.x)

Unexpected console statement

const employees = getEmployees(list);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreachable code - const employees = getEmployees(list) on line 35 is after the return statement and creates a recursive call. This should be at module level, not inside the function.


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log(getEmployees) logs the function reference itself, not the result. Should log the employees array returned by getEmployees.

console.log(getEmployees);
Comment on lines +32 to +37

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per task requirement #4, both functions should be called at module level (outside any function), not nested inside getEmployees. Move these three lines (32, 35, 36) outside the function.



}

// write code here
Loading