done#6121
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! I am approving your solution as it meets all the core functional requirements. The BEM methodology and SCSS features are used effectively, and the layout is fully responsive as required.
I have a couple of small suggestions to make your code even better:
- The file
src/styles/font.scssis unused and imports Google Fonts, which goes against the project's code style guidelines. It's best to remove this file since you've correctly linked the fonts inindex.html. - In
src/styles/nav.scss, thetransitionproperty order is unconventional. For better readability, the standard syntax istransition: color $transition-duration ease-in-out;.
These are minor points for future reference. Great job overall!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| @@ -0,0 +1 @@ | |||
| @import 'https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700&display=swap'; | |||
There was a problem hiding this comment.
According to the Code Style Rules, importing Google Fonts within an SCSS file is not allowed. All fonts should be linked in the <head> of the HTML file, which you have already done correctly in index.html. This file is also not imported anywhere, so it's unused. Please remove this file to comply with the project's guidelines.
| color: $primary; | ||
| font-weight: 500; | ||
| font-size: 12px; | ||
| transition: ease-in-out $transition-duration color; |
There was a problem hiding this comment.
This is a minor point, but the order of the values in your transition property is unconventional. The standard syntax is transition: <property> <duration> <timing-function>. It's a good practice to follow this order for better readability and to avoid potential issues in some browsers. Please adjust it to transition: color $transition-duration ease-in-out;.
2 participants
No description provided.