Finalização catálogo com BEM e responsividade#6122
Finalização catálogo com BEM e responsividade#6122eg3844540-svg wants to merge 13 commits intomate-academy:masterfrom
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on the overall structure and functionality! The responsive grid, hover effects, and semantic HTML are all implemented correctly. However, this submission requires changes because a core requirement was not met.
Your SCSS files use hardcoded values (e.g., 200px, #060b35, 300ms) for sizes, colors, and transitions. This violates a key task requirement to use variables for repeated values to improve maintainability [CHECKLIST ITEM #2]. Please create a _variables.scss partial to store these values and use them throughout your styles.
Additionally, the Roboto font is imported in index.html, but Arial is specified in index.scss. Please update the font-family to use the correct font. Once these issues are addressed, your solution will be ready for approval.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| .catalog { | ||
| padding: 50px 40px; | ||
|
|
||
| &__grid { | ||
| display: grid; | ||
| justify-content: center; | ||
| gap: 46px 48px; | ||
| grid-template-columns: repeat(1, 200px); | ||
|
|
||
| @media (min-width: 488px) { | ||
| grid-template-columns: repeat(2, 200px); | ||
| } | ||
|
|
||
| @media (min-width: 768px) { | ||
| grid-template-columns: repeat(3, 200px); | ||
| } | ||
|
|
||
| @media (min-width: 1024px) { | ||
| grid-template-columns: repeat(4, 200px); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This file contains several 'magic numbers' (hardcoded pixel values for paddings, gaps, widths, and breakpoints). This violates checklist item #2: 'Repeated sizes and special colors are put to variables'.
Please define and use SCSS variables for these values. For example:
$catalog-padding: 50px 40px;$grid-gap: 46px 48px;$card-width: 200px;$breakpoint-sm: 488px;
This same issue exists in _card.scss and _nav.scss for colors, sizes, and transition durations.
| .nav__link { | ||
| color: #060b35; | ||
| text-decoration: none; | ||
| transition: color 300ms; | ||
| } | ||
|
|
||
| .nav__link:hover { | ||
| color: #00acdc; | ||
| } | ||
|
|
||
| .nav__link.is-active { | ||
| font-weight: bold; | ||
| } |
There was a problem hiding this comment.
This file uses hardcoded values for colors (#060b35, #00acdc) and transition duration (300ms). This violates checklist item #2: 'Repeated sizes and special colors are put to variables'.
Please define these values as SCSS variables (e.g., in a separate _variables.scss file) and reuse them here and in other style files. This improves maintainability.
| .card { | ||
| width: 200px; | ||
| padding: 16px; | ||
| border: 1px solid #ccc; | ||
| border-radius: 8px; | ||
| transition: transform 300ms; | ||
| } |
There was a problem hiding this comment.
This file uses many 'magic numbers' and hardcoded color values (e.g., 200px, #ccc, 300ms). This violates checklist item #2: 'Repeated sizes and special colors are put to variables'. Please define SCSS variables for these values and use them throughout your styles to make the code more maintainable.
|
|
||
| body { | ||
| margin: 0; | ||
| font-family: Arial, sans-serif; |
There was a problem hiding this comment.
The Roboto font is linked in the HTML file, but Arial is specified here as the primary font. To ensure the intended design is applied, you should use the imported font: font-family: 'Roboto', sans-serif;.
2 participants
❗️ Copy this
Checklistto thePull Requestdescription after links, and put- [x]before each point after you checked it.cardandstarseach in their own fileelements,modifiersandpseudo-classesstars--Nmodifiers work as expected (Highlight firstNstars)