Skip to content

commit#778

Open
bohdanmayor wants to merge 5 commits intomate-academy:masterfrom
bohdanmayor:develop
Open

commit#778
bohdanmayor wants to merge 5 commits intomate-academy:masterfrom
bohdanmayor:develop

Conversation

@bohdanmayor
Copy link
Copy Markdown

@bohdanmayor bohdanmayor commented Apr 25, 2023

Comment thread src/index.html Outdated
<fieldset class="fieldset">
<legend>An interesting fact about you!</legend>
<div class="field">
<label for="yes">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant label. with this label click on text Do you love cats select first radio button

Comment thread src/index.html
type="email"
id="user-email"
placeholder="email@example.com"
>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the email input element so it can be submitted with the form. For example: name="email"

Comment thread src/index.html
type="password"
id="user-password"
minlength="6"
>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the password input element so it can be submitted with the form. For example: name="password"

Comment thread src/index.html
<label for="color">
What is your favorite color?
<input type="color" id="color">
</label>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the color input element so it can be submitted with the form. For example: name="favorite-color"

Comment thread src/index.html
type="time"
id="time"
step="1"
>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the time input element so it can be submitted with the form. For example: name="bed-time"

Comment thread src/index.html
<label class="field" for="comments">
Comments:
<textarea id="comments"></textarea>
</label>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the textarea element so it can be submitted with the form. For example: name="comments"

Comment thread src/index.html
<div class="field">
<label for="accept-term">
I accept the term of the agreement
<input type="checkbox" id="accept-term">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the checkbox input element so it can be submitted with the form. For example: name="accept-term"

@bohdanmayor bohdanmayor requested a review from etojeDenys April 26, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants