HTMLform#803
Open
usernameluke wants to merge 2 commits intomate-academy:masterfrom
Open
Conversation
Anastasiia-Svintsova
suggested changes
Jul 7, 2023
Anastasiia-Svintsova
left a comment
Anastasiia-Svintsova
left a comment
There was a problem hiding this comment.
-
Add working links here.
-
Fix labels here. It doesn't work correctly
Comment on lines
+15
to
+18
| <form | ||
| action="https://mate-academy-form-lesson.herokuapp.com/create-application" | ||
| method="post" | ||
| > |
There was a problem hiding this comment.
Suggested change
| <form | |
| action="https://mate-academy-form-lesson.herokuapp.com/create-application" | |
| method="post" | |
| > | |
| <form | |
| action="https://mate-academy-form-lesson.herokuapp.com/create-application" | |
| method="post" | |
| > |
Comment on lines
+28
to
+29
| </label> | ||
| <label class="form"> |
There was a problem hiding this comment.
Don't forget to add empty lines between multiline sibling blocks of HTML. Fix it everywhere
Suggested change
| </label> | |
| <label class="form"> | |
| </label> | |
| <label class="form"> |
| Full date of birth: | ||
| <input type="date" name="date"> | ||
| </label> | ||
| <div class="form"> |
There was a problem hiding this comment.
This div seems redundant. Just wrap the input into the label as you did it above
Comment on lines
+96
to
+100
| <input | ||
| type="radio" | ||
| name="catLover" | ||
| value="no" | ||
| > |
There was a problem hiding this comment.
Check the code style here
Suggested change
| <input | |
| type="radio" | |
| name="catLover" | |
| value="no" | |
| > | |
| <input | |
| type="radio" | |
| name="catLover" | |
| value="no" | |
| > |
polosanya
approved these changes
Jul 10, 2023
Comment on lines
+154
to
+155
| <label class="form"> | ||
| Would you recommend us? |
There was a problem hiding this comment.
Suggested change
| <label class="form"> | |
| Would you recommend us? | |
| <label class="form"> | |
| Would you recommend us? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK