done Case transformer server GH task#1090
done Case transformer server GH task#1090maximtsyrulnyk wants to merge 2 commits intomate-academy:masterfrom
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on the server implementation! The overall structure, request handling, and validation logic are well done. However, changes are needed because a specific error message does not exactly match the task requirements, which will cause the automated tests to fail.
In src/createServer.js, the error message for an unsupported case currently ends with a period. Please remove the period to ensure the message is an exact match to the one specified in the task description.
Once you've made that small correction, this will be ready for approval!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/createServer.js
Outdated
| 'This case is not supported. Available cases:' + | ||
| ' SNAKE, KEBAB, CAMEL, PASCAL, UPPER.', |
There was a problem hiding this comment.
This error message is almost correct, but the task description specifies the message without a period at the end. Please ensure all error messages match the requirements exactly.
|
edited code according reccommendations |
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This is so close to perfect! Your server logic is well-implemented, but there's one small detail from the previous review that needs to be addressed. The error message for an unsupported case in src/createServer.js still has a period at the end. This is causing the automated tests to fail because the task requires an exact string match. Please update the message to be exactly: This case is not supported. Available cases: SNAKE, KEBAB, CAMEL, PASCAL, UPPER. Once that small change is made, everything will be ready for approval. Great work on the rest of the implementation!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| const TO_CASE_REQUIRED_MESSAGE = | ||
| '"toCase" query param is required. Correct request is: "/<TEXT_TO_CONVERT>?toCase=<CASE_NAME>".'; | ||
| const INVALID_CASE_MESSAGE = | ||
| 'This case is not supported. Available cases: SNAKE, KEBAB, CAMEL, PASCAL, UPPER.'; |
There was a problem hiding this comment.
This is very close! The task requires the error message to be an exact match. Please remove the period (.) at the end of this string to match the requirement: This case is not supported. Available cases: SNAKE, KEBAB, CAMEL, PASCAL, UPPER.
3 participants
done Case transformer server GH task