First Request#923
Open
Sany8k wants to merge 8 commits intomate-academy:masterfrom
Open
Conversation
Sany8k
changed the title
etojeDenys
suggested changes
Mar 8, 2026
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
great job, just a few fixes to make
- it would be better to open this link in a new tab
- after selecting that capacity on that phone, an error page appears
- add some arrows to these buttons
Denys-Kravchuk9988
suggested changes
Mar 8, 2026
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
A few things to improve:
- It's better to add dropdown caret for these selects
- I would recommend to add
cursor: pointer;when user hovers this section
Denys-Kravchuk9988
suggested changes
Mar 8, 2026
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Almost done!
One tiny bug to solve:
when I close the select's list the caret is in wrong position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DEMOLINK]https://sany8k.github.io/react_phone-catalog/#/