Conversation
Member
|
This suppresses unused variable warnings while keeping the extra variables themselves. Is there a reason
such as maintaining ABI compatability with something else for this?
|
Member
|
@lukefromdc each instance should be reviewed, but as those are parameters (not variables) they are part of that function's API. If it's used as a callback or virtual function, the signature has to match what the callers use, whether it's used or not. It's very common in GObject code to have unused parameters because it heavily relies on callbacks and virtual functions, but not all parameters are needed for all cases. I'm wondering if doing this makes much sense because of this BTW: does this change get rid of everything? And do we want to have |
Member
|
I would suggest the latter: less risk of typos sneaking into code, and normal builders who are not MATE developers
do not have any use for these warnings.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unused variable warnings with
G_GNUC_UNUSED.