chore: add typecheck script and enable strict type checking#662
Open
thkruz wants to merge 1 commit into
Open
Conversation
32c3aed to
0538cba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The project had no type-checking step. ESLint is configured with
typescript-eslint's recommended ruleset, which only runs syntactic lint rules; it performs no type-checking and there was notscinvocation anywhere in the npm scripts. As a result, type errors were never caught bynpm run lint, CI, or any other command.Types of changes
It is an adjustment to the build/development process, not a modification to the production code.
Checklist: