Add try/except import on LobsterSet module from pymatgen#1437
Merged
JaGeo merged 2 commits intomaterialsproject:mainfrom Mar 26, 2026
Merged
Add try/except import on LobsterSet module from pymatgen#1437JaGeo merged 2 commits intomaterialsproject:mainfrom
JaGeo merged 2 commits intomaterialsproject:mainfrom
Conversation
Member
|
@tomdemeyere there is a second change that we need to account for. The LobsterNeighbor class is at a different place as well. You could use try and except as well. |
Member
|
I should read more carefully. The bug shows up in LobsterPy. I have started to fix it but the changes in pymatgen had just a few side effects.... JaGeo/LobsterPy#433 I will probably need another hour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the recent pymatgen changes the LobsterSet class have been displaced without deprecation, for now a try/except approach seems like the best (but ugly) compromise. Fix #1436