Skip to content

[WIP] Update static collections#1401

Merged
tsmathis merged 5 commits intodevelopfrom
misc-static
Mar 23, 2026
Merged

[WIP] Update static collections#1401
tsmathis merged 5 commits intodevelopfrom
misc-static

Conversation

@esoteric-ephemera
Copy link
Copy Markdown
Collaborator

@esoteric-ephemera esoteric-ephemera commented Mar 19, 2026

Updating data models / fields for static collections per discussion with @tsmathis:

  • Data schema for Atlas search results in Synthesis data
  • Ensure structure field in surface properties is structure and not CIF str
  • Replace grain boundaries cif field with structure

@esoteric-ephemera esoteric-ephemera changed the base branch from main to develop March 19, 2026 23:34
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.03%. Comparing base (7eb5760) to head (038726f).

Files with missing lines Patch % Lines
emmet-core/emmet/core/grain_boundary.py 60.00% 6 Missing ⚠️
emmet-core/emmet/core/surface_properties.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1401      +/-   ##
===========================================
- Coverage    86.06%   86.03%   -0.03%     
===========================================
  Files          243      243              
  Lines        19373    19399      +26     
===========================================
+ Hits         16673    16690      +17     
- Misses        2700     2709       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmathis tsmathis merged commit 80916c9 into develop Mar 23, 2026
12 checks passed
@tsmathis tsmathis deleted the misc-static branch March 23, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants