Skip to content

A possible issue with not deepcopying job kwargs #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utf merged 2 commits into from
Apr 13, 2026
Merged

A possible issue with not deepcopying job kwargs #860

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44575dd
failing test to demonstrate a possible issue with not deepcopying job…
vineetbansal Mar 13, 2026
828c29d
strict=True for xfail
vineetbansal Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions tests/core/test_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1415,3 +1415,31 @@ def test_job_magic_methods():

# test __hash__
assert hash(job1) != hash(job2) != hash(job3)


@pytest.mark.xfail(
reason="Mutating one job's config mutates all others created by that decorator.",
strict=True,
)
def test_job_decorator_config_shared():
from jobflow import JobConfig, job

config = JobConfig(manager_config={"key": "original"})

@job(config=config)
def add_configured(a, b):
return a + b

job1 = add_configured(1, 3)
job2 = add_configured(2, 3)

assert job1.config.manager_config == {"key": "original"}
assert job2.config.manager_config == {"key": "original"}

job1.config.manager_config["key"] = "changed"

# job2 should still have the original value.
assert job2.config.manager_config == {"key": "original"}, (
f"Expected job2.config.manager_config to be {{'key': 'original'}}, "
f"but got {job2.config.manager_config!r} — shared instance bug confirmed."
)
Loading