implement local version of lenient_issubclass#863
Open
gpetretto wants to merge 1 commit intomaterialsproject:mainfrom
Open
implement local version of lenient_issubclass#863gpetretto wants to merge 1 commit intomaterialsproject:mainfrom
gpetretto wants to merge 1 commit intomaterialsproject:mainfrom
Conversation
Contributor
|
Thank you very much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a report from @FabiPi3, the current version of pydantic (2.12.5) raises a warning that the pydantic.v1 module is not compatible with python 3.14 or later. While this has apparently been fixed in pydantic and the warning will be gone in the next release, support for the pydantic.v1 will likely be dropped in v3: pydantic/pydantic#10033.
I think it is worth getting rid of that import right away, considering that the usage of that module is minimal in jobflow.
The implementation is slightly different from the original (https://github.com/pydantic/pydantic/blob/8ba0d00782cc453ab9542f8932ef2b2a47614594/pydantic/v1/utils.py#L181) since I think that we don't want the
lenient_issuclassto ever raise an error.