[WIP] Add I/O interface with Metalwalls#3193
Closed
chiang-yuan wants to merge 3 commits intomaterialsproject:masterfrom
Closed
[WIP] Add I/O interface with Metalwalls#3193chiang-yuan wants to merge 3 commits intomaterialsproject:masterfrom
chiang-yuan wants to merge 3 commits intomaterialsproject:masterfrom
Conversation
janosh
reviewed
Sep 12, 2023
Member
There was a problem hiding this comment.
I think better to be explicit here and write out the name: pymatgen/io/metalwalls/__init__.py
Contributor
Author
There was a problem hiding this comment.
Thanks @janosh! Will change that when I get back to this. It has been put off in my TODOs and is going to stale for a while.
3c23114 to
36e289c
Compare
d725325 to
dca98be
Compare
e3fbc67 to
41e6d99
Compare
Member
|
Thanks for your contribution. However, we have moved this to pymatgen-core. Please resubmit a PR there when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same PR but without dirty commit from other branch. The input classes are mostly finished.
runtime.inptfileStructureto metalwallsdata.inptformatDetailed implementation
Input
Top level parameter keywords
Top level block keywords
thermostat
barostat
velocity
species
molecules
electrodes
dipoles_and_electrodes
interactions
external_field
plumed
output
Data
Output
None
Checklist
ruff.mypy.duecredit@due.dcitedecorators to reference relevant papers by DOI (example)