Add a save parameter for chargemol calculation to select whether save the output files, use "link" rather than "copy" for the input file of chargemol calc, add mpi function to run chargemol.#3456
Closed
RedStar-Iron wants to merge 39 commits intomaterialsproject:masterfrom
Conversation
Add "IWAVPR" to the tuple of int_keys.
Add the mpi function when running the chargemol program.
Update chargemol_caller.py
import multiprocessing
Comment the warning while check the path. Revise the command of mpirun.
Change the command to run chargemol
Contributor
Author
Job script to run chargemol program. |
Change the previous copy to link for CHGCAR, POTCAR, AECCAR0, AECCAR2. Add the save parameter, to control whether save the output files of chargemol.
Signed-off-by: Six_ligand <49940294+RedStar-Iron@users.noreply.github.com>
add self._from_data_dir() to mode with outputs saved
…is indeed a list of strings after the None filtering.
2.Replace typing.Optional with the | None. 3.Replace typing.Union with the | operator for union types.
Contributor
Author
|
Hi Dr. @Andrew-S-Rosen, Are you available to have look the remaining problem in this commit? I have tried several methods to handle this problem but it still remains. Do you have some experiences to solve this kind of problem? Thanks a lot! |
Member
|
@RedStar-Iron: Apologies, but I unfortunately don't have time to look at this PR. @chiang-yuan and/or @janosh might be interested, however. |
3c23114 to
36e289c
Compare
d725325 to
dca98be
Compare
e3fbc67 to
41e6d99
Compare
Member
|
Thanks for your contribution. However, we have moved this to pymatgen-core. Please resubmit a PR there when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised Content
saveparameter to control whether save the output files fromchargemolcalculationlinkrather thancopyforCHGCAR, POTCAR, ARCCAR0 and ARCCAR2during the calculationmpirunforchargemolcalculation