Fix: BSPlotterProjected._Orbitals_SumOrbitals() method#4167
Open
ShengLin1001 wants to merge 4 commits intomaterialsproject:masterfrom
Open
Fix: BSPlotterProjected._Orbitals_SumOrbitals() method#4167ShengLin1001 wants to merge 4 commits intomaterialsproject:masterfrom
ShengLin1001 wants to merge 4 commits intomaterialsproject:masterfrom
Conversation
… is not None, because Nonetype couldn't be iterable
Author
|
And I also have a question, why we need run this elif len(dictio[elt][0]) > 1:for example code, the len("dxy") = 3, what's meaning of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Ensure BSPlotterProjected._Orbitals_SumOrbitals() checks if sum_morbs is not None, as a NoneType object cannot be iterated.
Summary
Major changes:
Description
When running the following code, I encountered an error in the get_projected_plots_dots_patom_pmorb() method, which uses _Orbitals_SumOrbitals(). The error occurred because sum_morbs was None, making it non-iterable.
This fix addresses the issue by ensuring that sum_morbs is checked to confirm it is not None before any iteration, especially when plotting a single orbital. The order of statements has been adjusted accordingly.
Example Code to Reproduce:
This change ensures more robust handling of cases where sum_morbs is None to prevent runtime errors.