Avoid and fix Deprecation Warnings#4617
Open
kavanase wants to merge 17 commits intomaterialsproject:masterfrom
Open
Avoid and fix Deprecation Warnings#4617kavanase wants to merge 17 commits intomaterialsproject:masterfrom
kavanase wants to merge 17 commits intomaterialsproject:masterfrom
Conversation
Update import paths to avoid deprecation warnings Signed-off-by: Seán Kavanagh <51478689+kavanase@users.noreply.github.com>
Signed-off-by: Seán Kavanagh <51478689+kavanase@users.noreply.github.com>
…ompatibility`` to avoid deprecation warnings from ``pymatgen`` code
…tries`` to avoid deprecation warnings from ``pymatgen`` code
…patibility.entry_tools`` to avoid deprecation warnings from ``pymatgen`` code
…matgen.core.molecule_structure_comparator`` to avoid deprecation warnings from ``pymatgen`` code
…patibility.exp_entries`` to avoid deprecation warnings from ``pymatgen`` code
…alysis.compatibility.correction_calculator``
Contributor
Author
|
These warnings were flagged by our warnings tests in |
Contributor
Author
|
Fyi, the issue with |
…structure_matcher`` to avoid internal deprecation warnings with ``pymatgen``
…gen.analysis.compatibility.computed_entries``
….structure_analyzer`` to avoid internal deprecation warnings with ``pymatgen``
… avoid internal deprecation warnings with ``pymatgen``
…v`` to avoid internal deprecation warnings with ``pymatgen``
Member
|
Thanks. Do you mind resolving the conflicts? I believe you just need to delete the entire docs directory. |
Contributor
Author
|
Yep certainly can do, though I think @DanielYang59 and I were going to try digging in a bit more to avoid any other instances of this first, and seemed like there was still some discussion about the repo structure (#4595 – I will add my thoughts there now). |
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
entry_toolsandcorrection_calculator).I would note that this PR update is likely not exhaustive; there are likely other usages of deprecated code in the
pymatgencodebase following the big restructuring withpymatgen-core. It would be helpful to search through theDeprecationWarnings added in #4595 and check that the rest of the codebase has been updated accordingly. @DanielYang59 perhaps you could check this as you have a good understanding of the current code structure?I imagine some code in
pymatgen-corelikely needs to be updated too, in a similar fashion.There is also some issues with
MPResterrelated to the code structure changes and deprecations, I will raise an issue for that now.