Add no_std support#877
Open
AverageHelper wants to merge 3 commits intomathematic-inc:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to use this crate in a
no_stdpackage, but its references tostdare a holdback. Since this crate seems to only depend on things re-exported fromcoreandalloc, those references can be replaced without change in functionality, while enabling the use of this crate in constrained environments.I tested these changes locally in another crate, and compiled against a target which does not have access to
std. The unit tests all pass, so hopefully this is all good! I also added a CI check to ensureno_stdsupport going forward.Apologies in advance for the slight added maintenance burden ^^;