Skip to content

Adding negative tests for partial read workflow #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jm9176 merged 2 commits into from
Jul 14, 2025
Merged

Adding negative tests for partial read workflow #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c103ff
Adding negative tests for partial read workflow
jm9176 Jul 10, 2025
ef351ba
Address feedback
jm9176 Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions test/tZarrRead.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,24 +136,35 @@ function invalidFilePath(testcase)

function invalidPartialReadParams(testcase)
% Verify zarrread errors when invalid partial read
% Start/Stride/Count are used

% Start/Stride/Count are used.
zpath = testcase.ArrPathReadSmall; % a 2D array, 3x4

% Wrong number of dimensions in comparison to the array
errID = 'MATLAB:Zarr:badPartialReadDimensions';
wrongNumberOfDimensions = [1,1,1];
testcase.verifyError(...
@()zarrread(zpath,Start=wrongNumberOfDimensions),...
errID);
testcase.verifyError(...
@()zarrread(zpath,Stride=wrongNumberOfDimensions),...
errID);
testcase.verifyError(...
@()zarrread(zpath,Count=wrongNumberOfDimensions),...
errID);

%TODO: negative values, wrong datatypes, out of bounds

wrongDims = [1,1,1];

@krisfed krisfed Jul 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment here that the number of dimensions is wrong? I understand making the variable name shorter, but without that information it can be hard to quickly figure out what is "wrong" about these dimensions.

@jm9176 jm9176 Jul 14, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated comment.

testcase.verifyError(@()zarrread(zpath,Start=wrongDims),errID);
testcase.verifyError(@()zarrread(zpath,Stride=wrongDims),errID);
testcase.verifyError(@()zarrread(zpath,Count=wrongDims),errID);

% Invalid type
errID = 'MATLAB:validators:mustBeNumericOrLogical';
testcase.verifyError(@()zarrread(zpath,"Start",""),errID);
testcase.verifyError(@()zarrread(zpath,"Stride",""),errID);
testcase.verifyError(@()zarrread(zpath,"Count",""),errID);

% Negative values
inpVal = [-1 1];
errID = 'MATLAB:validators:mustBePositive';
testcase.verifyError(@()zarrread(zpath,"Start",inpVal),errID);
testcase.verifyError(@()zarrread(zpath,"Stride",inpVal),errID);
testcase.verifyError(@()zarrread(zpath,"Count",inpVal),errID);

% Input out of bounds
inpVal = [100 200];
errID = 'MATLAB:Python:PyException';
testcase.verifyError(@()zarrread(zpath,"Start",inpVal),errID);
%testcase.verifyError(@()zarrread(zpath,"Stride",inpVal),errID);

@krisfed krisfed Jul 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this one commented out?

testcase.verifyError(@()zarrread(zpath,"Count",inpVal),errID);
end
end
end