Count tracked visits from the log tables in the CNIL masking test - #228
Open
nathangavin wants to merge 6 commits into
Open
Count tracked visits from the log tables in the CNIL masking test#228nathangavin wants to merge 6 commits into
nathangavin wants to merge 6 commits into
Conversation
Bump plugin version to 6.0.0 and require Matomo >=6.0.0-b1,<7.0.0-b1.
* Update min_php system test expected files for PHP 8.1 With the Matomo minimum PHP version raised to 8.1, the min_php_ baseline cell now runs on PHP 8.1 instead of 7.2. PHP 8.0 made sorting stable, so campaign rows with tied values aggregate/order as they already do on 8.2/8.5 - the regenerated min_php_ output is byte-identical to the existing max baseline. Refs matomo-org/matomo#24638. * adjust actions for php 8.1
* Run plugin tests against MySQL 8.0 and MariaDB 10.6 The workflow inherited the shared action's MySQL 5.7 default, which is below Matomo's new minimum. Pin the database-backed jobs to the supported floor: PluginTests now runs a MySQL 8.0 + MariaDB 10.6 matrix, and the UI/JS jobs run on MySQL 8.0. * Only upload plugin test artifacts for the MySQL matrix leg PluginTests runs a MySQL + MariaDB matrix; the upload-artifacts condition matched both legs and uploaded twice. Restrict the upload to the MySQL leg.
… Puppeteer 24) (#225) * Update expected UI screenshots for the new headless Chrome (Node 24 / Puppeteer 24) * Re-sync expected UI screenshots for the new headless Chrome after rebase Rendering drift only (identical content, minor line-height/AA shifts) under the new headless Chrome used by the migrated screenshot-testing harness. * Fix loaded_ecommerce capture: grow viewport so the sticky header stays at top Under Puppeteer 24 an element screenshot of a report taller than the viewport leaves the DataTable's position:sticky column header floating mid-table (captured at the scrolled viewport position). Grow the viewport to fit the whole report before capturing so no scrolling occurs and the header renders at the top. The live browser shows the report at this (wider) width, so the capture now matches what users actually see. * Sync corrected loaded_ecommerce screenshot (header at top) * Run the plugin UI tests on Node 24 Match the Node 24 / Puppeteer 24 screenshot-testing stack; the UI job was still pinned to Node 16.
Teal brand screenshots on 6.x-dev plugin base; synced from matomo-org/matomo run 30405694397.
Live.getCounters now applies privacy-safe rounding while a data-rounding policy such as CNIL is active, which would collapse the small exact counts this test relies on (1 and 2 both become 10). Read the tracked counts directly from the log tables so the masked-campaign assertions stay rounding-immune. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
caddoo
previously approved these changes
Aug 3, 2026
caddoo
left a comment
caddoo
left a comment
There was a problem hiding this comment.
Need a review from @matomo-org/plugin-reviewers
sgiehl
dismissed stale reviews from lachiebol and caddoo
August 10, 2026 06:52
The base branch was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Live.getCountersnow applies privacy-safe rounding while a data-rounding policy such as CNIL is active.ForceNewVisitTest's masked-campaign case enables CNIL and asserts small exact counts (1 vs 2) read throughLive.getCounters, which would collapse to 10 under rounding.This reads the tracked counts directly from the log tables so those assertions stay rounding-immune.
Supports matomo-org/matomo#24929.
Checklist
Review
🤖 Generated with Claude Code