ReportHeader - update UI screenshots (feature branch) - #235
Draft
tzi wants to merge 2 commits into
Draft
Conversation
The DataTable search moved from the table footer into the shared ReportHeader (matomo-org/matomo#24986), which changes every report screenshot.
The report header search restyles the shared form controls, which moves the help panel text on the plugin settings page down by a pixel. That was captured on the previous report-header branch, but this branch was cut from 6.x-dev, where the same file had been recaptured for the TrackingSpamPrevention integration (#233) against a core without the restyle, so the adjustment was lost. Byte-identical to what CI renders for the report header branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature branch for the report header work in this plugin: it carries the 7 expected UI screenshots regenerated for the DataTable search moving from the table footer into the shared report header.
Merged into this branch
Impact
None visible to users: expected test screenshots only.
Step by step tests
Nothing to exercise by hand. The screenshots come from the CI artifacts of matomo-org/matomo#24986 and are verified by the core feature branch, matomo-org/matomo#25059.
Note on the UI tests
The plugin's own UI jobs run against core
6.x-dev, which does not yet contain the report header change, so they compare these screenshots against a core that renders the old footer search and go red. They turn green once matomo-org/matomo#25059 lands. Merge this only together with that PR.Checklist