Drive the report actions from the header menu - #237
Open
tzi wants to merge 2 commits into
Open
Conversation
The visualisation switcher and the configure items moved into the menu behind the report header's 3-dots trigger, which twig renders outside the table, so a selector scoped by `[data-report]` no longer reaches them.
tzi
force-pushed
the
report-header-actions-move
branch
from
August 17, 2026 12:26
c40c793 to
0e5e920
Compare
Taken from the run that first had the spec change above, so the two flat-page tests reach the flatten entry through the header menu and capture a flattened report instead of erroring before their assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drives the flatten action from the report header's actions menu, which is where matomo-org/matomo#25064 moves it.
The visualisation switcher and the configure items no longer render as icon bars around the table. They are entries in the single menu behind the report header's 3-dots trigger, and the header is rendered outside the
.dataTable, so a selector scoped by[data-report="…"]cannot reach them any more. One call site scoped that way and now climbs to the wrapper holding both the header and the table; the other is scoped by widget id, which already contains both.Base branch
This targets
feature-new-report-header, because the selectors it uses only exist once the core change lands. On6.x-devthe spec would fail.Impact
None visible to users: this changes a UI test only.
Step by step tests
Automated
UI-plugins (MarketingCampaignsReporting)on ReportHeader - Move the report actions into a dropdown menu matomo#25064, which pins this commit.👁️ The flatten specs open the actions menu and pass, where they previously failed with
No element found for selector: .dropdownConfigureIcon.Checklist