Adds code to encrypt sensitive values before storing in DB, #PG-5236 - #38
Merged
Conversation
lachiebol
reviewed
Jul 13, 2026
lachiebol
left a comment
Contributor
There was a problem hiding this comment.
LGTM,
something from codex, does this apply to this case?
1. Updates/5.2.0.php writes directly in doUpdate() and never declares previewable migrations or calls $updater->executeMigrations(__FILE__, $this->getMigrations($updater)) around Updates/5.2.0.php:27. This violates matomo-migrations-workflow and means the update is not represented in Matomo’s normal migration
preview/execution flow. The branch-new update file is allowed from an immutability perspective, but the migration shape should be fixed before merge.
Contributor
Author
I noticed this first, but since we are encrypting, good to not push in logs |
lachiebol
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds code to encrypt sensitive values before storing in DB
Issue No
#PG-5236
Steps to Replicate the Issue
core:updateChecklist