Skip to content

Adds code to encrypt sensitive values before storing in DB, #PG-5236 - #38

Merged
AltamashShaikh merged 2 commits into
5.x-devfrom
PG-5236-encrypt
Jul 16, 2026
Merged

Adds code to encrypt sensitive values before storing in DB, #PG-5236#38
AltamashShaikh merged 2 commits into
5.x-devfrom
PG-5236-encrypt

Conversation

@AltamashShaikh

Copy link
Copy Markdown
Contributor

Description

Adds code to encrypt sensitive values before storing in DB

Issue No

#PG-5236

Steps to Replicate the Issue

  1. Checkout this PR
  2. Run core:update
  3. Execute the schedule reports and it should still work as it is
  4. Verify the setting values, they should be encrypted now

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [✔] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

@AltamashShaikh AltamashShaikh added the Needs Review For pull requests that need a code review. label Jul 9, 2026
@AltamashShaikh
AltamashShaikh requested a review from a team July 13, 2026 05:05

@lachiebol lachiebol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

something from codex, does this apply to this case?

  1. Updates/5.2.0.php writes directly in doUpdate() and never declares previewable migrations or calls $updater->executeMigrations(__FILE__, $this->getMigrations($updater)) around Updates/5.2.0.php:27. This violates matomo-migrations-workflow and means the update is not represented in Matomo’s normal migration
     preview/execution flow. The branch-new update file is allowed from an immutability perspective, but the migration shape should be fixed before merge.

@AltamashShaikh

Copy link
Copy Markdown
Contributor Author

LGTM,

something from codex, does this apply to this case?

  1. Updates/5.2.0.php writes directly in doUpdate() and never declares previewable migrations or calls $updater->executeMigrations(__FILE__, $this->getMigrations($updater)) around Updates/5.2.0.php:27. This violates matomo-migrations-workflow and means the update is not represented in Matomo’s normal migration
     preview/execution flow. The branch-new update file is allowed from an immutability perspective, but the migration shape should be fixed before merge.

I noticed this first, but since we are encrypting, good to not push in logs

@AltamashShaikh
AltamashShaikh merged commit 2b568bd into 5.x-dev Jul 16, 2026
9 checks passed
@AltamashShaikh
AltamashShaikh deleted the PG-5236-encrypt branch July 16, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants