ci: Fix permissions for CircleCI redirector#107
ci: Fix permissions for CircleCI redirector#107QuLogic wants to merge 1 commit intomatplotlib:mainfrom
Conversation
dstansby
left a comment
There was a problem hiding this comment.
Sorry, a hasty approval that was wrong. I think this should at least have permissions set to read at the top, but I'm not sure that will make it work - I think it should be showing up in the list of actions but isn't?
|
It looks like a request is still failing: https://github.com/matplotlib/mpl-brochure-site/actions/runs/18119545816/job/51561596670#step:2:17 - I'm looking at https://github.com/matplotlib/mpl-brochure-site/settings/secrets/actions and it seems like the correct tokens need generating/setting as I can't see any there. Happy to merge this as it's a step in the right direction, or wait until the tokens are setup? (I will try later to see if I have the right perms to set them up if no-one else does first) |
It won't work until merged since it's on the
But I'm not sure about which tokens were needed; maybe @tacaswell remembers? |
As in #102 (comment)