fix(openproject): preserve URL protocol in getOpenProjectSafeUrl#1354
Open
MacherelR wants to merge 2 commits into
Open
fix(openproject): preserve URL protocol in getOpenProjectSafeUrl#1354MacherelR wants to merge 2 commits into
MacherelR wants to merge 2 commits into
Conversation
Half-Shot
reviewed
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1353
Fix: OpenProject
getOpenProjectSafeUrlhardcodeshttp://causing HTTPS origin mismatchProblem
When a user runs
!hookshot openproject add https://op-instance/projects/<id>against an OpenProject instance served over HTTPS, the command always fails with:Root cause
In
src/Connections/SetupConnection.ts,getOpenProjectSafeUrlsanitises the user-provided URL and returns a normalised form to pass toprovisionConnection. However, it hardcodes thehttp://scheme regardless of the input:So a user input of
https://op.example.com/projects/42produceshttp://op.example.com/projects/42.provisionConnectionthen callsvalidateOpenProjectConnectionState, which asserts:Since
config.openProject.baseURL.originishttps://op.example.combut the safe URL origin ishttp://op.example.com, the check always fails on HTTPS instances.Testing
!hookshot openproject add https://op.example.com/projects/8fails with origin mismatch