Skip to content

MSC4140: use auth for delayed event management#5340

Merged
AndrewFerr merged 2 commits into
developfrom
af/msc4140-authed-mgmt
May 26, 2026
Merged

MSC4140: use auth for delayed event management#5340
AndrewFerr merged 2 commits into
developfrom
af/msc4140-authed-mgmt

Conversation

@AndrewFerr

@AndrewFerr AndrewFerr commented May 22, 2026

Copy link
Copy Markdown
Member

Do this to let ratelimiting apply per user instead of per source IP address, if the server supports that.

See element-hq/synapse#19794

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Do this to let ratelimiting apply per user instead of per source IP
address, if the server supports that.

See element-hq/synapse#19794

@dbkr dbkr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment to say that's why it's doing an authed request please?

@AndrewFerr

Copy link
Copy Markdown
Member Author

Can you add a comment to say that's why it's doing an authed request please?

0f2c39c adds a comment adapted from the commit message of 7889b99.

@dbkr dbkr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AndrewFerr AndrewFerr added this pull request to the merge queue May 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 26, 2026
@AndrewFerr AndrewFerr added this pull request to the merge queue May 26, 2026
Merged via the queue into develop with commit ec54b54 May 26, 2026
41 checks passed
@AndrewFerr AndrewFerr deleted the af/msc4140-authed-mgmt branch May 26, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants