Skip to content

Fix client filters#3510

Open
weeman1337 wants to merge 1 commit into
mainfrom
fix-client-filter
Open

Fix client filters#3510
weeman1337 wants to merge 1 commit into
mainfrom
fix-client-filter

Conversation

@weeman1337

Copy link
Copy Markdown
Contributor

Description

The client data was restructured in
686c08b.
Update the filter CSS to match the new structure.

Related issues

closes #3509

Role

Website WG

@weeman1337 weeman1337 requested a review from a team as a code owner July 4, 2026 17:53
@weeman1337 weeman1337 added the bug Something is broken. label Jul 4, 2026
The client data was restructured in
686c08b.
Update the filter CSS to match the new structure.

Signed-off-by: weeman <weeman@frankfurt.ccc.de>
@weeman1337 weeman1337 force-pushed the fix-client-filter branch from 9c6d170 to eb83982 Compare July 4, 2026 18:22
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 4, 2026

Copy link
Copy Markdown

Deploying matrix-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: eb83982
Status: ✅  Deploy successful!
Preview URL: https://da2a410d.matrix-website.pages.dev
Branch Preview URL: https://fix-client-filter.matrix-website.pages.dev

View logs

@MTRNord MTRNord left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the immediate issue.

I just wonder where Widgets are coming from as no client actually seems to advertise support it and its not anymore on the feature list(s) in the client details. But I think that doesnt block this PR.

@HarHarLinks

Copy link
Copy Markdown
Contributor

Seems to fix the immediate issue.

It completely mismatches the actual list of features when you open a client though?

@HarHarLinks

HarHarLinks commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

<div class="filter-option">
<input id="feature-e2ee" type="checkbox">
<label for="feature-e2ee">E2EE</label>
</div>
<div class="filter-option">
<input id="feature-spaces" type="checkbox">
<label for="feature-spaces">Spaces</label>
</div>
<div class="filter-option">
<input id="feature-voip-1to1" type="checkbox">
<label for="feature-voip-1to1">Native 1:1 calls</label>
</div>
<div class="filter-option">
<input id="feature-widgets" type="checkbox">
<label for="feature-widgets">Widgets</label>
</div>
<div class="filter-option">
<input id="feature-threads" type="checkbox">
<label for="feature-threads">Threads</label>
</div>
<div class="filter-option">
<input id="feature-sso" type="checkbox">
<label for="feature-sso">SSO (Enterprise login)</label>
</div>
<div class="filter-option">
<input id="feature-multi-account" type="checkbox">
<label for="feature-multi-account">Multi-account</label>
</div>
<div class="filter-option">
<input id="feature-multi-language" type="checkbox">
<label for="feature-multi-language">Multi-language</label>
</div>

@MTRNord

MTRNord commented Jul 5, 2026

Copy link
Copy Markdown
Member

Seems to fix the immediate issue.

It completely mismatches the actual list of features when you open a client though?

Huh? Going through the filters and clicking a random client did lead me to the filtered for thing. Thats what I meant there. I did notice that it lists widgets which isnt on the other list though. But it fixed filtering for the rest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is broken.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

*Features* filter does not work on ecosystem/clients/

3 participants