Skip to content
This repository was archived by the owner on Jul 21, 2025. It is now read-only.

feat: custom sms provider using config#562

Open
AzikDeveloper wants to merge 5 commits intomatrix-org:mainfrom
AzikDeveloper:main
Open

feat: custom sms provider using config#562
AzikDeveloper wants to merge 5 commits intomatrix-org:mainfrom
AzikDeveloper:main

Conversation

@AzikDeveloper
Copy link

Pull Request Checklist

  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fix a bug that prevented receiving messages from other servers." instead of "Move X method from EventStore to EventWorkerStore.".
    • Include 'Contributed by Your Name.' or 'Contributed by @your-github-username.' — unless you would prefer not to be credited in the changelog.
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off

@AzikDeveloper AzikDeveloper requested a review from a team as a code owner May 1, 2023 14:56
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally this will need a changelog file / sign-off as the PR template says.


self.provider_class = sydent.sms.openmarket.OpenMarketSMS
try:
sms_provider = cfg.get("sms", "provider")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation for this configuration option.

@clokep
Copy link
Member

clokep commented Sep 5, 2023

@AzikDeveloper Do you have interest in finishing this off? See the comments above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants