This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add a test which ensures that new tables get PRIMARY KEYs.#16648
Open
reivilibre wants to merge 2 commits into
Open
Add a test which ensures that new tables get PRIMARY KEYs.#16648reivilibre wants to merge 2 commits into
reivilibre wants to merge 2 commits into
Conversation
erikjohnston
left a comment
erikjohnston
left a comment
Member
There was a problem hiding this comment.
Should we not enforce that the table either has a primary key or a replica identity?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a history, even recently, of not using PRIMARY KEYs and many of the cases seem tragically just because someone was unaware that it is good practice / maybe cribbed off earlier schema deltas. In many cases a
UNIQUEindex was created instead when that could've been aPRIMARY KEY.This PR adds a test that flags up missing PRIMARY KEYs.
Base:
developOriginal commit schedule, with full messages:
Add a PRIMARY KEY lint