Skip to content

Feature/automate linting #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matrop merged 6 commits into from
May 3, 2025
Merged

Feature/automate linting #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e838f08
feat: add format checking
May 3, 2025
73d8c29
fix: apply formatting
May 3, 2025
d4e0a66
feat: add linting
May 3, 2025
c4621e2
fix: apply mypy suggestions
May 3, 2025
ff5c766
fix: apply formatting
May 3, 2025
317c538
feat: add sast via bandit
May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/ci-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ env:
POETRY_VERSION: 2.1.2

jobs:
unit-tests:
name: Run Unit Tests
test-and-check:
name: Test and Check Python Code
runs-on: ubuntu-latest
container: python:3.12-slim # TODO: How to use a variable here?
env:
Expand All @@ -38,10 +38,22 @@ jobs:
- name: Run Pytest
run: |
$POETRY_HOME/bin/poetry run pytest tests/ -v

- name: Run Format Check
run: |
$POETRY_HOME/bin/poetry run black --check src/ tests/

- name: Run Linting
run: |
$POETRY_HOME/bin/poetry run mypy src/

- name: Run SAST
run: |
$POETRY_HOME/bin/poetry run bandit src/ -r -ll # Report medium vulnerabilities or higher

another-job:
name: I will eventually be a useful job
runs-on: ubuntu-latest
needs: unit-tests
needs: test-and-check
steps:
- run: echo "The unit tests were successful!"
Loading