-
Notifications
You must be signed in to change notification settings - Fork 218
fix: replace crypto.randomUUID with fallback for non-secure contexts #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mzazon
wants to merge
3
commits into
matt1398:main
from
mzazon:fix/crypto-random-uuid-non-secure-context
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * Generate a UUID v4 string. | ||
| * | ||
| * `crypto.randomUUID()` is only available in **secure contexts** (HTTPS or | ||
| * localhost). When the app is served over plain HTTP on a LAN IP (e.g. | ||
| * Docker accessed from another machine), the browser will not expose | ||
| * `randomUUID`. This helper falls back to `crypto.getRandomValues()` which | ||
| * is available in all modern browsers regardless of secure context. | ||
| * | ||
| * @see https://github.com/matt1398/claude-devtools/issues/132 | ||
| */ | ||
| export function generateUUID(): string { | ||
| if (typeof crypto.randomUUID === 'function') { | ||
| return crypto.randomUUID(); | ||
| } | ||
|
|
||
| // Fallback: construct a v4 UUID from getRandomValues | ||
| const bytes = crypto.getRandomValues(new Uint8Array(16)); | ||
| // Set version (4) and variant (RFC 4122) | ||
| bytes[6] = (bytes[6] & 0x0f) | 0x40; | ||
| bytes[8] = (bytes[8] & 0x3f) | 0x80; | ||
|
|
||
| const hex = Array.from(bytes, (b) => b.toString(16).padStart(2, '0')).join(''); | ||
| return `${hex.slice(0, 8)}-${hex.slice(8, 12)}-${hex.slice(12, 16)}-${hex.slice(16, 20)}-${hex.slice(20)}`; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved robustness and consistency, it's better to use
globalThis.crypto. The optional chaining (?.) onrandomUUIDprevents aReferenceErrorin environments wherecryptomight not be defined. UsingglobalThisis also more portable across different JavaScript environments (e.g. window, worker).This also makes the usage consistent with the fallback path which will rely on
globalThis.crypto.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this as-is. This code only runs in browser renderers where
cryptois always defined (it's been a web standard since IE 11). Thetypeof crypto.randomUUID === 'function'check already guards the missing method safely.The
globalThis.crypto?.suggestion is also inconsistent — it uses optional chaining on the check but not on the fallback (globalThis.crypto.getRandomValues()), so ifcryptowere somehow undefined, the fallback would throw instead of the feature-detect.