Allow the route parameter in the route object to be a function#77
Open
krasiyan wants to merge 9 commits intomatteofigus:masterfrom
Open
Allow the route parameter in the route object to be a function#77krasiyan wants to merge 9 commits intomatteofigus:masterfrom
route parameter in the route object to be a function#77krasiyan wants to merge 9 commits intomatteofigus:masterfrom
Conversation
moved building the final request url from the 'suites-manager' to the 'request-agent' wip fixing tests
…is not a function
…on' scenario including the proper resolving of the route in the service
added note on the possible to have 'route' as a function
…method and request href
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to provide a synchronous function as the
routeparameter's value. The function will be executed and the full URL (using the service root) will be resolved before every request.Please note that when
routeis a function, theRequestin theRequest detailsgraph from the report will look likePOST Dynamic route on http://service.url/.