Add LIKE support to cloud API#1155
Merged
yasserfaraazkhan merged 1 commit intomasterfrom Apr 10, 2026
Merged
Conversation
📝 WalkthroughWalkthroughModified DNS filter matching in the installation store to support wildcard patterns. When a DNS filter contains the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
saturninoabril
approved these changes
Apr 6, 2026
saturninoabril
left a comment
There was a problem hiding this comment.
Thanks @yasserfaraazkhan, LGTM.
esarafianou
approved these changes
Apr 6, 2026
andrleite
approved these changes
Apr 6, 2026
NARSimoes
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The servers created when running mobile or desktop e2e have a hex in the DNS name.
Deleting the server is failing silently as the DNS look up is for exact name and doesn't account for dynamic hex for the servers.