Skip to content

use mise tooling - #8

Merged
Willyfrog merged 1 commit into
masterfrom
mise
Jul 23, 2026
Merged

use mise tooling#8
Willyfrog merged 1 commit into
masterfrom
mise

Conversation

@Willyfrog

Copy link
Copy Markdown
Contributor

Summary

Since we use mise for a lot of projects, I added it here as well.

Some context on its use in playbooks https://hub.mattermost.com/pde/pl/ad5r875f3fyctpmtdggxke8gqr
it also solved some issues I had with playbooks in the past and helps create a similar build across devices.

Ticket Link

No ticket

@Willyfrog Willyfrog self-assigned this Jul 23, 2026
@Willyfrog
Willyfrog requested a review from catalintomai July 23, 2026 10:29
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a .mise.toml file that configures Go and Node versions, Go environment overrides, and Mise tasks delegating to project make targets.

Changes

Mise configuration

Layer / File(s) Summary
Toolchain and task definitions
.mise.toml
Defines Go and Node tool versions, Go tooling environment variables, and tasks for installation, checks, tests, builds, development, and deployment through corresponding make commands.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly reflects the added Mise tooling and build-task configuration.
Description check ✅ Passed The description is related to the change and explains why Mise was added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mise

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.mise.toml (1)

3-3: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Refresh the Node.js pin or document the compatibility requirement.

Node.js 24.13.1 is valid, but 24.18.0 is the current v24 LTS patch release. Keeping this older pin may omit subsequent fixes; update it or document why 24.13.1 is required. (nodejs.org)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.mise.toml at line 3, Update the Node.js version pin in the mise
configuration from 24.13.1 to the current v24 LTS patch release, 24.18.0; only
retain the older pin if the project documents a specific compatibility
requirement for it.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.mise.toml:
- Line 3: Update the Node.js version pin in the mise configuration from 24.13.1
to the current v24 LTS patch release, 24.18.0; only retain the older pin if the
project documents a specific compatibility requirement for it.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 25f3613b-da2d-4f18-9f57-67ca115e9916

📥 Commits

Reviewing files that changed from the base of the PR and between 598cb9c and 8c34f4b.

📒 Files selected for processing (1)
  • .mise.toml

@catalintomai

Copy link
Copy Markdown
Collaborator

@Willyfrog - does this overlap with or complements - #6 ?

@Willyfrog

Copy link
Copy Markdown
Contributor Author

I mostly use it for local dev, but it could also help with CI.

it basically stablishes the tooling so it always runs with the right version of Go/Node, and provides some other QoL improvements like the run scripts.

@Willyfrog
Willyfrog merged commit b6a7ef3 into master Jul 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants