Test notice 11.5#473
Merged
Merged
Conversation
📝 WalkthroughWalkthroughUpdated in-app server upgrade notices in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@notices.json`:
- Around line 132-139: The patch notice reuses the same id "patch_upgrade2"
which prevents admins who dismissed the previous notice from seeing the new
10.11.13 announcement; update the notice object's "id" to a new unique
identifier (e.g., "patch_upgrade2_v2" or "patch_upgrade_10_11_13") in
notices.json, ensure any client-side checks that track viewed-state use the new
id, and do not change other fields like "serverVersion" or "localizedMessages"
so the new notice is treated as distinct for viewed-state persistence.
- Line 101: The description value for the JSON object with key "description"
contains insecure http:// links; update each link to use https:// (e.g., change
http://docs.mattermost.com/... to https://docs.mattermost.com/...) so all
referenced docs (CJK Database Search, AI Channel Summarization, Agents Web
Search, Upgrading) and the Channel Auto-Translation URL use HTTPS consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PR: #472
Summary by CodeRabbit