Skip to content

Test notice 11.5#473

Merged
yasserfaraazkhan merged 1 commit into
masterfrom
notice-11-5
Mar 19, 2026
Merged

Test notice 11.5#473
yasserfaraazkhan merged 1 commit into
masterfrom
notice-11-5

Conversation

@yasserfaraazkhan
Copy link
Copy Markdown
Contributor

@yasserfaraazkhan yasserfaraazkhan commented Mar 19, 2026

Release PR: #472

Summary by CodeRabbit

  • Chores
    • Updated in-app notices for server versions 11.5 and 10.11.13
    • Adjusted notice display dates and version conditions

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

Updated in-app server upgrade notices in notices.json. Modified the primary notice from version 11.4 to 11.5 with revised version conditions, display dates, and English localized messaging. Also updated a patch notice for the 10.11 ESR release with adjusted version ranges and message content.

Changes

Cohort / File(s) Summary
Server Upgrade Notices
notices.json
Updated notice ID from server_upgrade_v11.4 to server_upgrade_v11.5. Adjusted server version condition from <11.4 to <11.5. Advanced display date from 2026-02-17 to 2026-03-18. Updated English title and description to reference Mattermost 11.5 features. Updated a separate 10.11 ESR patch notice with expanded version range (<=10.11.12), matching display date (2026-03-18), and revised messaging referencing version 10.11.13.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Test notice 11.5' is partially related to the changeset but lacks clarity and specificity about the actual changes being made. Consider using a more descriptive title that clearly indicates the main change, such as 'Update in-app notices for Mattermost 11.5 and 10.11.13 releases' to better convey the purpose of the PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch notice-11-5
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@notices.json`:
- Around line 132-139: The patch notice reuses the same id "patch_upgrade2"
which prevents admins who dismissed the previous notice from seeing the new
10.11.13 announcement; update the notice object's "id" to a new unique
identifier (e.g., "patch_upgrade2_v2" or "patch_upgrade_10_11_13") in
notices.json, ensure any client-side checks that track viewed-state use the new
id, and do not change other fields like "serverVersion" or "localizedMessages"
so the new notice is treated as distinct for viewed-state persistence.
- Line 101: The description value for the JSON object with key "description"
contains insecure http:// links; update each link to use https:// (e.g., change
http://docs.mattermost.com/... to https://docs.mattermost.com/...) so all
referenced docs (CJK Database Search, AI Channel Summarization, Agents Web
Search, Upgrading) and the Channel Auto-Translation URL use HTTPS consistently.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 204d0c66-f073-4738-af26-98ecadc41a90

📥 Commits

Reviewing files that changed from the base of the PR and between b09de31 and e1f4e30.

📒 Files selected for processing (1)
  • notices.json

Comment thread notices.json
Comment thread notices.json
@yasserfaraazkhan yasserfaraazkhan merged commit fc25c6f into master Mar 19, 2026
2 checks passed
@yasserfaraazkhan yasserfaraazkhan deleted the notice-11-5 branch March 19, 2026 01:54
@coderabbitai coderabbitai Bot mentioned this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant