Print the offset in the hex output#18
Open
zeroSteiner wants to merge 1 commit intomatterpreter:masterfrom
Open
Print the offset in the hex output#18zeroSteiner wants to merge 1 commit intomatterpreter:masterfrom
zeroSteiner wants to merge 1 commit intomatterpreter:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the hexdump to use the address (the raw offset within the scanned file) for the left hand column. This means that users know where to look for the contents for further inspection without knowing that they need to take the "end of bad bytes offset" value and subtract the length of the printed data.