whitelist Mc- and Mac- last names#5
Open
brchristian wants to merge 1 commit intomattstevens:masterfrom
Open
Conversation
|
If you replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #1, this extension works like a dream except with words that start with "mc" or "mac", which get horribly butchered.
For instance:
...which, I think you'll agree, is...not the desired behavior.
In fact, even a great many words that seem like surnames that should get a second capital letter in fact do not. Consider:
None of these should get a second capital in most cases.
This PR includes a whitelist for common names that generally should get a second capital, so that other words beginning with "mac" will be properly left with a single capital.