refactor(core): simplify telemetry setup and harden runtime log control#1
Merged
refactor(core): simplify telemetry setup and harden runtime log control#1
Conversation
Simplify subscriber construction, decouple Tokio metrics from OTLP-specific wiring, harden OTLP configuration validation, and make TelemetryGuard shutdown idempotent. This keeps production setup leaner, improves shutdown reliability, and adds integration coverage for lifecycle and README-style configuration paths.
Wrap installed OTLP filters in live reload layers, serialize mutable filter state with a single mutex, and avoid inverted lock ordering between stdout and OTLP updates. This prevents successful control-plane updates from targeting orphaned state, removes a router deadlock path, and strengthens regression coverage for runtime filter behavior.
Update the README and crate-level docs to reflect idempotent shutdown, best-effort drop teardown, configurable Tokio metrics, and the Tokio rt-multi-thread requirement. Keeping the durable docs aligned with runtime behavior helps users choose explicit shutdown on current-thread runtimes and understand the supported configuration paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configuration validation.
immediately.
deadlock between stdout and OTLP updates.
Tokio metrics, and rt-multi-thread requirement.
Why
latent deadlock path; both are now covered by regression tests.
multi-thread runtimes, and users have clear guidance on supported configuration paths.
Tests
plus expanded init_log_control.rs and readme_common_config.rs for lifecycle and README-style
configs.