This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Convert relative bind mounts to absolute paths#49
Open
onnimonni wants to merge 2 commits into
Open
Conversation
| # Prepare Hostconfig Bind mounts by converting | ||
| # relative paths into absolute paths | ||
| # | ||
| def prepare_volume_binds |
Owner
There was a problem hiding this comment.
Can you please add/adjust the specs to cover this fix?
Since the tests are passing without this fix, seems like we have an uncovered case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes annoying error: