feat(androidx): moved to androidx#42
Open
Daavidaviid wants to merge 2 commits intomauron85:masterfrom
Daavidaviid:feat/migrate-to-androidx
Open
feat(androidx): moved to androidx#42Daavidaviid wants to merge 2 commits intomauron85:masterfrom Daavidaviid:feat/migrate-to-androidx
Daavidaviid wants to merge 2 commits intomauron85:masterfrom
Daavidaviid:feat/migrate-to-androidx
Conversation
|
@mysport12 can you see why the build failed in CI? |
|
@mauron85 are you still maintaining the repo's? |
Contributor
@hb2708 This is @Daavidaviid's PR not mine. The tests fail for not being able to find symbols after the migration to AndroidX. I have a separate PR that just changes the order of applicationId checks in VERSIONS.gradle. In any event if you are here due to build failures while using the RN repo that has this as a dependency, you can get around the failure by linking manually |
|
Hey @mysport12 sorry misunderstood you are the pr creator. I was on this bcoz of androidx issues but the just managed to solve that using jettyfier |
CoooWeee
added a commit
to CoooWeee/background-geolocation-android
that referenced
this pull request
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theses changes made the library work on one of my project. And I think it might be easier for other people to contribute to this project in the future if it's natively using androidx.