dbutil: rewrite query placeholders without regexp#37
Merged
Conversation
tulir
reviewed
Jun 11, 2026
tulir
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the SQLite dialect,
mutateQueryrunspositionalParamPattern.ReplaceAllStringon every query that goes throughLoggingExecable, so the regexp engine cost is paid on every single Exec/Query/QueryRow. This replaces it with a hand-rolled scan doing the same$Nto?Nrewrite: queries without placeholders return the input string with zero allocations, and queries with placeholders cost one allocation for the rewritten string.The new test checks the function against the old regexp on every combination of up to 4 characters from a relevant alphabet plus some realistic queries, so the behavior is provably identical. Benchmark on a typical INSERT:
I also considered caching rewritten queries, but dynamically built queries (IN clauses, mass inserts) would make the cache unbounded, and the scanner already gets it down to the single unavoidable allocation.
Before/after heap profiles from a whatsmeow ping/pong benchmark that uses this library with SQLite, viewable in speedscope: before, after.
mutateQuerydrops from 111MB to 22MB of allocations over the run, with the regexp machinery replaced by the single allocation of the rewritten string.