Fetch full XMA media after embedded URL download failure#271
Open
saulcapital wants to merge 1 commit into
Open
Fetch full XMA media after embedded URL download failure#271saulcapital wants to merge 1 commit into
saulcapital wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix XMA media conversion when the embedded media URL is stale.
Instagram posts and reels can contain embedded signed CDN URLs that expire. The converter currently tries to download that embedded URL first, and only calls fetchFullXMA after that download succeeds, so if the embedded URL is stale, the bridge gives up before reaching fetchFullXMA, even though fetchFullXMA can independently ask the Instagram API for fresh media data and a new downloadable media URL.
This fixes the failed embedded-download path to call fetchFullXMA too, using the existing notice as the fallback.
The existing fallback behavior is preserved: if XMA fetching is disabled, or if the fresh fetch/reupload also fails, fetchFullXMA returns the notice.