login: Migrate to Native #106
Open
highesttt wants to merge 11 commits into
Open
Conversation
2fa not supported yet
tulir
reviewed
Jul 1, 2026
Comment on lines
+11
to
+14
| const ChromeVersion = "149" | ||
| const UserAgent = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/" + ChromeVersion + ".0.0.0 Safari/537.36" | ||
| const SecCHUserAgent = `"Google Chrome";v="` + ChromeVersion + `", "Chromium";v="` + ChromeVersion + `", "Not)A;Brand";v="24"` | ||
| const OSName = "Windows" |
Member
There was a problem hiding this comment.
These are wrong and probably need to be reverted. The TLS library hasn't been updated for Chrome 148+ yet, 141 is still equivalent to 120. The order in sec-ch headers is random and doesn't need to be changed unless implementing proper randomization like how chrome does it
| } else if seconds > 268435455 { | ||
| seconds = 268435455 | ||
| } | ||
| timeBytes := []byte{byte(seconds >> 24), byte(seconds >> 16), byte(seconds >> 8), byte(seconds)} |
Member
There was a problem hiding this comment.
Suggested change
| timeBytes := []byte{byte(seconds >> 24), byte(seconds >> 16), byte(seconds >> 8), byte(seconds)} | |
| timeBytes := binary.BigEndian.AppendUint32(nil, uint32(seconds)) |
| seconds = 268435455 | ||
| } | ||
| timeBytes := []byte{byte(seconds >> 24), byte(seconds >> 16), byte(seconds >> 8), byte(seconds)} | ||
| msBytes := []byte{byte((timestampMillis % 1000) >> 8), byte(timestampMillis % 1000)} |
Member
There was a problem hiding this comment.
Suggested change
| msBytes := []byte{byte((timestampMillis % 1000) >> 8), byte(timestampMillis % 1000)} | |
| msBytes := binary.BigEndian.AppendUint16(nil, timestampMillis % 1000) |
Comment on lines
+676
to
+700
| func jetfuelTimezone() string { | ||
| if timezone := strings.TrimSpace(os.Getenv("TWITTER_JETFUEL_TIMEZONE")); timezone != "" { | ||
| return timezone | ||
| } | ||
| if local := time.Local.String(); strings.Contains(local, "/") { | ||
| return local | ||
| } | ||
| _, offset := time.Now().Zone() | ||
| switch offset { | ||
| case -10 * 60 * 60: | ||
| return "Pacific/Honolulu" | ||
| case -9 * 60 * 60: | ||
| return "America/Anchorage" | ||
| case -8 * 60 * 60: | ||
| return "America/Los_Angeles" | ||
| case -7 * 60 * 60: | ||
| return "America/Denver" | ||
| case -6 * 60 * 60, -5 * 60 * 60: | ||
| return "America/Chicago" | ||
| case -4 * 60 * 60: | ||
| return "America/New_York" | ||
| default: | ||
| return "UTC" | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Are these really supposed to be hardcoded?
Member
There was a problem hiding this comment.
Everything in this file looks extremely fragile
highesttt
changed the title
highesttt
force-pushed
the
highest/plat-37693
branch
from
July 16, 2026 15:58
0971495 to
ec225d0
Compare
highesttt
changed the title
tulir
reviewed
Jul 16, 2026
| contextURL, _ := json.Marshal(castleTokenContextURL) | ||
| identifierJSON, _ := json.Marshal(identifier) | ||
| return fmt.Sprintf(`(async () => { | ||
| const scriptURL = %s; |
Member
There was a problem hiding this comment.
This should go into a separate file that's embedded with go:embed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Checklist