Open
Conversation
hamishwillee
commented
Oct 19, 2022
hamishwillee
commented
Oct 19, 2022
| The following C `#defines` can be set in code in order to tune the setup for use on different platforms. | ||
|
|
||
| - `MAVLINK_USE_CONVENIENCE_FUNCTIONS` ([protocol.h](https://github.com/ArduPilot/pymavlink/blob/master/generator/C/include_v2.0/protocol.h)): Causes convenience functions to be defined, including: `_mav_finalize_message_chan_send()`, `_mavlink_send_uart()`, `_mavlink_resend_uart()`. To use, add `#define MAVLINK_USE_CONVENIENCE_FUNCTIONS` to your code. | ||
| - `MAVLINK_COMM_NUM_BUFFERS`: Sets the maximum number of comms buffers to be used (comms channels). |
Collaborator
Author
There was a problem hiding this comment.
Would I be correct in thinking that you might specify 1 if you knew you had a mavlink component that would only have one connection to the network?
hamishwillee
commented
Oct 19, 2022
julianoes
reviewed
Oct 24, 2022
hamishwillee
commented
Oct 25, 2022
Co-authored-by: Julian Oes <julian@oes.ch>
hamishwillee
commented
Oct 25, 2022
Collaborator
Author
|
@julianoes OK, I've integrated your suggestions, and have one further question: #492 (comment) If that's correct, is this otherwise OK to go in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mavlink/mavlink#44
@auturgy @julianoes This needs review - questions inline because most of what I did was guesses.
Note, there are other defines, but I think they are all internal.