Only send player state when changed event is emitted by game.controls#10
Open
gabehollombe wants to merge 1 commit into
Open
Only send player state when changed event is emitted by game.controls#10gabehollombe wants to merge 1 commit into
gabehollombe wants to merge 1 commit into
Conversation
NOTE: requires update to player-physics module to emit this event
Owner
|
Coincidentally I was also hacking up the server the other night (I've been at a conference in Australia for the last few days). I may not merge this directly but I'll do it manually in the next couple of days. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: requires update to player-physics module to emit this event
Corresponding pull request is here: max-mapper/player-physics#7
Addresses issue: TODO: Have client only send player's position/rotation on change #9