fix(ci): exclude GitHub index URLs from lychee link checker#1018
Merged
fix(ci): exclude GitHub index URLs from lychee link checker#1018
Conversation
The exclusion patterns for GitHub issue/PR/commit URLs required a trailing slash, so they matched `/issues/123` but not `/issues` (the index page). This caused lychee to check the index URLs, which intermittently return 502 on GitHub Actions. Remove the trailing slash from the patterns so they match both forms. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The macOS CI job failed because lychee (link checker) got a 502 Bad Gateway when checking
https://github.com/max-sixty/worktrunk/issues. The lychee config already excludes GitHub issue/PR/commit/actions URLs to avoid transient failures, but the exclusion patterns required a trailing slash:This matches
/issues/123but not/issues(the index page). Six docs files link tohttps://github.com/max-sixty/worktrunk/issueswithout a trailing slash, so they weren't excluded and failed on a transient 502.Solution
Remove the trailing slash from the
commit,issues, andpullexclusion patterns so they match both index pages (/issues) and specific items (/issues/123). Theactionspattern already lacked a trailing slash and was unaffected.Alternatives considered
Could also add the specific URL
github.com/max-sixty/worktrunk/issuesas a separate exclusion, but fixing the generic patterns is more robust — it prevents the same issue for any GitHub repo URL referenced in docs.Testing
lychee --config .config/lychee.tomlon the six affected files — 0 errors (previously 6)/issues/123)cargo test --lib --binspasses (491 tests)🤖 Automated fix for failed run